This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Best current solution to handle all types of generic directives refs #86 #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art-archive#86 In the future, maybe there's a way to know the directive's parameters based on how its used in the template. For now, use the upper bounds because those are the lowest types and therefore can be relied upon in the template, and avoids the 'T is not subtype of String' errors. Refactoring: changed event typechecking to go off of a new type field on InputElement so that it could be deparameterized consistently at collection time rather than deparameterized everywhere its used. Same for outputs, but those already had an eventType field that was used everywhere. Opening new issue dart-archive#91 for some tricky subtleties in generic chains. Looks like this code should some day use `instatiateToBounds` but that will not do much typing without strong mode turned on, and has a bug that is open in their repo.
scheglov
approved these changes
Nov 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, maybe there's a way to know the directive's parameters
based on how its used in the template. For now, use the upper bounds
because those are the lowest types and therefore can be relied upon in
the template, and avoids the 'T is not subtype of String' errors.
Refactoring: changed event typechecking to go off of a new type field on
InputElement so that it could be deparameterized consistently at
collection time rather than deparameterized everywhere its used. Same
for outputs, but those already had an eventType field that was used
everywhere.
Opening new issue #91 for some tricky subtleties in generic chains.
Looks like this code should some day use
instatiateToBoundsbut thatwill not do much typing without strong mode turned on, and has a bug
that is open in their repo.