Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

misc: require Dart 2, fix deprecations, prepare to release 1.0.4 #12

Merged
merged 4 commits into from
Jul 12, 2018

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jul 12, 2018

Fixes dart-lang/tools#681
Fixes #8

@kevmoo kevmoo requested a review from munificent July 12, 2018 23:17
@@ -17,7 +15,7 @@ class Evaluator implements Visitor<bool> {

Evaluator(semantics)
: _semantics = semantics is Iterable
? DelegatingIterable.typed(semantics.toSet()).contains
? semantics.toSet().cast().contains

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be .cast<String>().

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

browser tests failing on travis with Dart 2-dev
3 participants