This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Make applicationConfigHome failures catchable #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Oct 11, 2021
jonasfj
approved these changes
Oct 11, 2021
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
It is not always possible to resolve any environment variables - but we still might want to query for the directory if it exists.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not always possible to resolve any environment variables - but we still might want to query for the directory if it exists.
We could also make
applicationConfigHomereturn a nullable result - but that would be a breaking change, and perhaps this case is better thought of as an exceptional condition.See: dart-lang/pub#3167 for context.