code_transformer pkg: unable to handle when dart exe is a symlink

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="96" height="96"hspace="10"> Issue by sethladd
Originally opened as dart-lang/sdk#20376

---

Consider this case:

/usr/local/bin/dart ==> /usr/local/Cellar/dart/1.5.3/bin/dart ==> /usr/local/Cellar/dart/1.5.3/libexec/bin/dart

This is what homebrew does.

The code in dartSdkDirectory assumed that which dart points to the physical location of dart.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

Looks like calling something like:

var file = new File(result.stdout.trim());
// check if file is a symlink
var realLocation = file.resolveSymbolicLinksSync();
    var sdkDir = path.dirname(path.dirname(reloadLocation));
    if (isSdkDir(sdkDir)) return sdkDir;

Or similar might do the trick?

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

FWIW this affects the zengen package on pub, which uses code_transformers. At least, it affects: code_transformers + dart sdk installed by homebrew + mac.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2152569?v=3" align="left" width="48" height="48"hspace="10"> Comment by blois

---

This code is a complete (and extremely unfortunate) hack around 16994.

Pub just recently added a pseudo-package '$sdk' which it sounds like we can use, though this will take a chunk of refactoring to change the resolver's use of dart sources from proxies of file-based sources to be asset-based sources. Though it may clean some stuff up by having everything be asset-based.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

Might also let it work cross-platform, too. Another benefit. :)

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch

---

We added the workaround to resolve the symlink for now in code_transformers 0.2.3+2 (see
https://codereview.chromium.org//795433002)

---

Added Fixed label.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd

---

Thanks very much!