Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

Conversation

@domesticmouse
Copy link
Contributor

No description provided.

@domesticmouse
Copy link
Contributor Author

Hey @devoncarew, as of Dart 2.10.3 I now need to run dartfmt twice to get it to reach a fixpoint. Any ideas on who I should hassle?

brett

@domesticmouse
Copy link
Contributor Author

Relevent log lines from Travis:

generate-protos
  protoc --dart_out=lib/src protos/dart_services.proto
  dartfmt --fix -w lib/src/protos
  Formatting directory lib/src/protos:
  Formatted dart_services.pb.dart
  Formatted dart_services.pbenum.dart
  Formatted dart_services.pbjson.dart
  Formatted dart_services.pbserver.dart
  dartfmt --fix -w lib/src/protos
  Formatting directory lib/src/protos:
  Formatted dart_services.pb.dart
  Unchanged dart_services.pbenum.dart
  Unchanged dart_services.pbjson.dart
  Unchanged dart_services.pbserver.dart

@domesticmouse domesticmouse merged commit ca7df77 into dart-archive:master Nov 2, 2020
@domesticmouse domesticmouse deleted the dart_2.10.3 branch November 2, 2020 07:32
@devoncarew
Copy link
Contributor

That's super odd and unexpected. I guess I would make sure that you are using the dartfmt from that sdk (2.10.3) - ensure that there's not some other version on your path. Do you know what the 2nd diff is?

2.10.3 is older, but if you can repro, you can file an issue w/ details against dart-lang/dart_style.

@domesticmouse
Copy link
Contributor Author

@devoncarew the delta that the second run of dartfmt modifies is captured in 012986a

I'm not seeing this issue on the 2.11 beta, nor 2.10.2.

@domesticmouse
Copy link
Contributor Author

Correction, I am also seeing this behaviour on 2.11.0-213.4.beta

@domesticmouse
Copy link
Contributor Author

Tracking issue raised: dart-lang/dart_style#971

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants