JsName and other metadata needs to live somewhere

[jmesserly]

Either in a package or in a SDK library.

import 'what_the_heck_do_I_write_here' show JsName;

@JsName('HTMLAwesomeElement')
class AwesomeElement extends HTMLElement { ... }

[jmesserly]

the most obvious place to put it now would be package:dev_compiler. It's a place, that we can add to, and works for testing/examples until we find something better.

[edit: emphasis]

[jmesserly]

Otherwise, everyone needs to copy+paste JsName, that seems bad right?

[jmesserly]

dart:js might probably the right place once it's stable. Or just skip it and use package:js, since not sure it would need to be in dart:

[jacob314]

dart:js seems pretty reasonable although I can also see the case for
package:js/annotations.dart
or even
package:dev_compiler
although I dislike that option as I expect these annotations will be consumed by code generators other than dev_compiler in the future.

[jmesserly]

although I dislike that option as I expect these annotations will be consumed by code generators other than dev_compiler in the future.

agreed, dev_compiler would be a temporary place.

[ochafik]

Noobie question: can we use the annotation before the import and still get the right element?

@JsName(name = 'window')
library dom;

import 'package:js/src/internal.dart' show JsName;

(here the annotation seems to have a type which lib is dom :-S)

[jacob314]

Yep you can use the annotation before the import. We rely on that all the
time for the
@js annotation.

On Thu, Oct 29, 2015 at 9:13 AM, Olivier Chafik [email protected]
wrote:

Noobie question: can we use the annotation before the import and still get
the right element?

@JsName(name = 'window')
library dom;

import 'package:js/src/internal.dart' show JsName;

(here the annotation seems to have a type which lib is dom :-S)

—
Reply to this email directly or view it on GitHub
#135 (comment)
.

[jmesserly]

Think the work here is done. Annotations found a good home.