Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

emit comments into generated JS #30

Closed
jmesserly opened this issue Jan 22, 2015 · 2 comments
Closed

emit comments into generated JS #30

jmesserly opened this issue Jan 22, 2015 · 2 comments

Comments

@jmesserly
Copy link
Contributor

idea: in a few methods like visitStatement, visitDeclaration, gather comments from the begin/end token stream and emit them in the desired location. This seems like a relatively simple way of preserving comments. We can then refine it over time to make locations more precise.

@jmesserly
Copy link
Contributor Author

I looked at this a bit, and it doesn't seem easy to do with our current non-sourcemap generation technique. Probably best to revisit when we have better source location tracking

edit: the main issue was, we either have to drop comments if we don't know where they go, or put them in a somewhat arbitrary place, and either way it feels a bit confusing in the output.

@jmesserly
Copy link
Contributor Author

This issue was moved to dart-lang/sdk#29347

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants