Skip to content

emit comments into generated JS #29347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmesserly opened this issue Apr 13, 2017 · 1 comment
Closed

emit comments into generated JS #29347

jmesserly opened this issue Apr 13, 2017 · 1 comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dev-compiler

Comments

@jmesserly
Copy link

From @jmesserly on January 22, 2015 17:26

idea: in a few methods like visitStatement, visitDeclaration, gather comments from the begin/end token stream and emit them in the desired location. This seems like a relatively simple way of preserving comments. We can then refine it over time to make locations more precise.

Copied from original issue: dart-archive/dev_compiler#30

@jmesserly jmesserly added web-dev-compiler P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug labels Apr 13, 2017
@jmesserly
Copy link
Author

jmesserly commented Apr 13, 2017

From @jmesserly on Feb 17, 2015

I looked at this a bit, and it doesn't seem easy to do with our current non-sourcemap generation technique. Probably best to revisit when we have better source location tracking

edit: the main issue was, we either have to drop comments if we don't know where they go, or put them in a somewhat arbitrary place, and either way it feels a bit confusing in the output.

@jmesserly jmesserly added the closed-not-planned Closed as we don't intend to take action on the reported issue label Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant