Atom plugin broken

[jmesserly]

It looks like the destructuring commit broke Atom (c9d909c) ... probably because they're on an older version of Chrome.

I think the new code has fallback logic already in some cases, so we could likely add a flag to turn that on always.

CC @devoncarew @vsmenon

[ochafik]

Sent a PR with a flag that disables destructuring (and filed #397 to track multiple runtimes).

@devoncarew, if running build_sdk.sh as part of the plugin's build is not an option, then I can flip _DESTRUCTURE_NAMED_PARAMS_DEFAULT to false and we'll re-enable it later.

[devoncarew]

if running build_sdk.sh as part of the plugin's build is not an option

It would be a lot more convenient to not have to do rebuild it :)

[vsmenon]

@devoncarew It looks like destructuring is behind a separate "--harmony-destructuring" in Chrome 45. Is that possible to turn on?

If not (or it doesn't work), we can disable it by default until Atom rolls forward.

@ochafik does anything break without destructuring?

[ochafik]

Destructuring fixes a pattern that breaks Closure's advanced mode, but it's not ready yet anyway, so can definitely compile the sdk without it (it will just grow 1% bigger ;-)).

If that's an acceptable middle ground, I suggest building the sdk without it, but leaving it as a default (and have the Atom build to add the --no-destructure-named-params flag), this way the generated code looks nicer by default.

[devoncarew]

sgtm!

I tried adding this to my start-up script:

var v8 = require('v8');
v8.setFlagsFromString('--harmony-destructuring');

which changed the failure mode, but did hit another exception.

[vsmenon]

@devoncarew Let us know if this is still an issue. Destructuring has been disabled by default.

We're also now regressing on Electron (the Chrome 47 version - non-trivial to move that earlier as our karma/travis version doesn't make it easy to run older Electron with --harmony). This would have caught the destructuring issue early.

[devoncarew]

Thanks! Will re-test w/ the latest DDC.

[jmesserly]

tentatively closing, let us know if it reoccurs!

[devoncarew]

Sorry, yup, it's working for me again.