This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Docs for no-implicit-casts and no-implicit-dynamic #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of fixing dart-lang/sdk#26782, I wanted to be able to link to some documentation for the Analyzer flags.
|
@leafpetersen does this new doc section look reasonable? I'm working on the CL to try these but wanted to have something to link to.
|
| ``` | ||
|
|
||
| It is designed to prevent accidental use of `dynamic` in code that does not intend to use it. It will lead to | ||
| more verbose dynamic code, so it may not be advisable for your code depending on its goals. |
There was a problem hiding this comment.
"It is designed" -> "This feature is designed". The second sentence feels unnecessary to me, and maybe more apologetic than needed. It's an optional feature, they can use it or not.
|
lgtm. |
improve optional flags documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of fixing dart-lang/sdk#26782, I wanted to be able to link to some documentation for the Analyzer flags.