Fix travis

[mit-mit]

Fix failing build: https://travis-ci.org/dart-lang/ffi

Ran dartfmt

[dcharkes]

lgtm

[mkustermann]

Don't we have the dartfmt checks enabled in .travis.yaml? How could this have been committed?

[mit-mit]

We do. Could this be a change in a new version of dartfmt?

[mkustermann]

I would say it's unlikely because such a change could cause massives amounts of user code to need re-formatting (the formatter should be very stable).

Are those checks correctly configured for travis? I see that other repositories configure it differently, e.g. https://github.com/dart-lang/stack_trace/blob/master/.travis.yml :

matrix:
  include:
    # Only validate formatting using the dev release
    # Formatted with 1.23.0+ which has (good) changes since 1.22.1
    - dart: dev
      dart_task: dartfmt

(I don't know how to correctly configure travis)

[mit-mit]

I don't know what happened, it seems to work: #11 Maybe we at some point merged even though travis was red?

…

On Thu, Oct 10, 2019 at 11:34 AM Martin Kustermann ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/src/utf8.dart <#8 (comment)>: > @@ -55,8 +55,7 @@ class Utf8 extends Struct<Utf8> { /// Returns a malloc-allocated pointer to the result. static Pointer<Utf8> toUtf8(String string) { final units = utf8.encode(string); - final Pointer<Uint8> result = - allocate<Uint8>(count: units.length + 1); + final Pointer<Uint8> result = allocate<Uint8>(count: units.length + 1); I would say it's unlikely because such a change could cause massives amounts of user code to need re-formatting (the formatter should be very stable). Are those checks correctly configured for travis? I see that other repositories configure it differently, e.g. https://github.com/dart-lang/stack_trace/blob/master/.travis.yml : matrix: include: # Only validate formatting using the dev release # Formatted with 1.23.0+ which has (good) changes since 1.22.1 - dart: dev dart_task: dartfmt (I don't know how to correctly configure travis) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADIDDCWEO3A3IPNOXSL2TADQN3ZKDANCNFSM4I7J3WNA> .