Skip to content
This repository was archived by the owner on Jan 17, 2024. It is now read-only.

Bump incremental version after adding allocation routines. #9

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

sjindel-google
Copy link
Contributor

No description provided.

Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a change log.

@sjindel-google
Copy link
Contributor Author

Please also add a change log.

Done.

@mit-mit
Copy link
Contributor

mit-mit commented Oct 10, 2019

Also, were those changes actually compatible with Dart 2.5.0 ?

@sjindel-google
Copy link
Contributor Author

Also, were those changes actually compatible with Dart 2.5.0 ?

I don't think so, because they rely on DynamicLibrary.process.

Copy link

@mkustermann mkustermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Michaels comment - if we need to bump the sdk constraint we can do it in this PR.

@mit-mit
Copy link
Contributor

mit-mit commented Oct 10, 2019

I published a version 0.1.2 that rolls back the allocation changes so that it's compatible with Dart 2.5.0.

For these allocation changes I suggest we raise the SDK constraint to Dart 2.6.0-dev.6.0 and that we publish this package to a pub.dev dev channel: https://dart.dev/tools/pub/publishing#publishing-prereleases

@sjindel-google sjindel-google merged commit b363e4a into master Oct 10, 2019
@mit-mit mit-mit deleted the sjindel.alloc branch October 11, 2019 11:28
dcharkes pushed a commit to dart-lang/native that referenced this pull request Jan 16, 2024
…t-archive/ffi#9)

* Bump incremental version after adding allocation routines.

* Changelog

* versions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants