This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Fix iterable_contains_unrelated_type #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvrh
commented
Mar 19, 2021
| @@ -151,12 +151,6 @@ abstract class B3 extends A3 {} | |||
|
|
|||
| bool takesB3(B3 b) => b.contains('a'); // OK | |||
|
|
|||
| abstract class A2 implements Iterable<String> {} | |||
There was a problem hiding this comment.
I remove it because this is the same case as A1 above
bwilkerson
approved these changes
Mar 19, 2021
Ah. That's a problem. It'd be good to get that updated. (fyi @scheglov) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#57708
This is an attempt to fix
iterable_contains_unrelated_type. This rule works in the test suite but not with a real SDK.This is because the [MockSdk] defines the hierarchy as
List<T> implements Iterable<T>(analyzer/mock_sdk.dart) while the real SDK definesList<T> extends EfficientLengthIterable<T>(sdk/core/list.dart)