Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

enhanced enum support for avoid_equals_and_hash_code_on_mutable_classes #3233

Merged
merged 5 commits into from
Feb 15, 2022
Merged

enhanced enum support for avoid_equals_and_hash_code_on_mutable_classes #3233

merged 5 commits into from
Feb 15, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Feb 15, 2022 •
edited
Loading

@devoncarew devoncarew mentioned this pull request Nov 19, 2024
Closed
31 tasks
@coveralls
Copy link

coveralls commented Feb 15, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 94.238% when pulling ed7b5f6 on avoid_equals_and_hash_code_on_mutable_classes_enums into 4782804 on master.

bwilkerson
bwilkerson reviewed Feb 15, 2022
View reviewed changes
@pq pq closed this Feb 15, 2022
@pq pq reopened this Feb 15, 2022
@pq
Copy link
Contributor Author

pq commented Feb 15, 2022

Updated to add a test to ensure we don't start reporting false positives down the road...

/cc @bwilkerson

@pq pq merged commit e37c01f into master Feb 15, 2022
@pq pq deleted the avoid_equals_and_hash_code_on_mutable_classes_enums branch February 15, 2022 20:20
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
enhanced enum support for `avoid_equals_and_hash_code_on_mutable_clas…
65ec797 
…ses` (dart-archive/linter#3233)

* enhanced enum support for `avoid_equals_and_hash_code_on_mutable_classes`

* - stale todo

* fmt

* test update

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @coveralls @bwilkerson