Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

fix pattern constant detection #4056

Merged
merged 3 commits into from
Feb 8, 2023
Merged

fix pattern constant detection #4056

merged 3 commits into from
Feb 8, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Feb 8, 2023

Follow-up from dart-lang/sdk#59029

The previous fix silenced linting on all collection literals (not just ones in constant patterns). 😬

/cc @bwilkerson

@github-actions github-actions bot added the linter-set-recommended Affects a rule in the recommended Dart rule set label Feb 8, 2023
@coveralls
Copy link

coveralls commented Feb 8, 2023

Coverage Status

Coverage: 95.664%. Remained the same when pulling f1eba16 on fix_constantPattern_detection into c183522 on main.

@pq pq merged commit 2a32d3f into main Feb 8, 2023
@pq pq deleted the fix_constantPattern_detection branch February 8, 2023 20:23
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
* fix pattern constant detection

* ++

* + test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter-set-recommended Affects a rule in the recommended Dart rule set
Development

Successfully merging this pull request may close these issues.

3 participants