Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

don't overreport prefer_void_to_null on cast patterns and as expressions #4208

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Mar 23, 2023

Fixes dart-lang/sdk#59089 (actually) 😊

/cc @srawlins

@github-actions github-actions bot added the linter-set-recommended Affects a rule in the recommended Dart rule set label Mar 23, 2023
@coveralls
Copy link

Coverage Status

Coverage: 96.329% (+0.0008%) from 96.328% when pulling 0bde51d on prefer_void_to_null_asExp_Pat_fixes into b416cd4 on main.

Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pq pq merged commit 40dd80c into main Mar 23, 2023
@pq pq deleted the prefer_void_to_null_asExp_Pat_fixes branch March 23, 2023 19:49
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter-set-recommended Affects a rule in the recommended Dart rule set
Development

Successfully merging this pull request may close these issues.

prefer_void_to_null should not be reported in a Cast Pattern or an As Expression
3 participants