This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Revert "Revert "unreachable_from_main: Report unreachable constructors (#4162)" (#4253)" #4337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is still ready for review. |
bwilkerson
approved these changes
May 23, 2023
Contributor
bwilkerson
left a comment
bwilkerson
left a comment
There was a problem hiding this comment.
Is this the same as the original PR? If so, lgtm. If not, I'll be happy to do a more careful review.
Contributor
Author
|
As the description notes, it is mostly a revert, plus a small fix for 'test_reflective_loader'. I think if you CTRL+F for test_reflective_loader in the diff, you can get a good handle on what is new. That new code is small relative to the reverted diff. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
dart-archive/linter#4162)" (dart-archive/linter#4253)" (dart-archive/linter#4337) This reverts commit ed1dc5d. Also: Add support for test_reflective_loader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b561905.
Also: Add support for test_reflective_loader