Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

add source-map support for the observable transfomer #29

Closed
DartBot opened this issue Jun 5, 2015 · 7 comments
Closed

add source-map support for the observable transfomer #29

DartBot opened this issue Jun 5, 2015 · 7 comments

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#12340


This is currently

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


(err hit enter too quickly)

This is currently blocked on having support for source-maps or composition in barback (see issue dart-archive/barback#6).

Once we have a good way to serve intermediate assets we can then add this to the apply function:

      var filename = path.basename(id.path);
      printer.add('\n//# sourceMappingURL=$filename.map');
      printer.build(url); // where url matches the barback url of the source asset.
      transform.addOutput(
          new Asset.fromString(id.addExtension('.map'), printer.map));

And fix tests accordingly.


Marked this as being blocked by dart-archive/barback#6.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Added this to the M8 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Removed this from the M8 milestone.
Added this to the Later milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Removed this from the Later milestone.
Added this to the M9 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/8616782?v=3" align="left" width="48" height="48"hspace="10"> Comment by clayberg


Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly


I don't think we need to do this any time soon. We're not altering line numbers so debugging should be okay. And we don't transform except when compiling to JS so it generally doesn't matter


Removed this from the 1.1 milestone.
Added this to the Later milestone.
Added NotPlanned label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/3276024?v=3" align="left" width="48" height="48"hspace="10"> Comment by anders-sandholm


Removed Library-Observe label.
Added Pkg-Observe label.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

1 participant