Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Add a test covering the highlighting of non-contiguous spans #116

Closed
wants to merge 1 commit into from

Conversation

stof
Copy link

@stof stof commented Sep 12, 2024

I ported this package to PHP as part of the scssphp project (as I'm porting dart-sass which uses this package). When collecting code coverage for the testsuite of my PHP port, I noticed that the code dealing with non-contiguous lines was not covered by the tests.
This PR adds a test covering this case.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@stof
Copy link
Author

stof commented Oct 15, 2024

Is anything missing here ? Can I get some feedback ?

@mosuem
Copy link
Contributor

mosuem commented Dec 11, 2024

Closing as the dart-lang/source_span repository is merged into the dart-lang/tools monorepo. Please re-open this PR there!

@mosuem mosuem closed this Dec 11, 2024
@mosuem
Copy link
Contributor

mosuem commented Dec 11, 2024

Also, I just saw that this PR never got a review. Hopefully the monorepo transfer will help in not having PRs like these fall through the cracks!

cc @devoncarew

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants