This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Cleanup #2
Merged
Cleanup #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Feb 15, 2019
example/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| The test folder provides a very basic usage example. | |||
There was a problem hiding this comment.
Not sure this is really worth having? but 🤷♂️
There was a problem hiding this comment.
Added a proper example.
| } catch (_) { | ||
| // Ignore any error | ||
| } catch (e) { | ||
| _logger.warning('Unable to encode outgoing message: $e'); |
There was a problem hiding this comment.
Note that this won't actually log anything anywhere by default... not necessarily an issue in itself but it might be worth documenting somewhere that you have to set up a log handler to see logs?
There was a problem hiding this comment.
Added a corresponding doc comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: dart-lang/tools#1633