Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Change the type on _onBatch to avoid relying on fuzzy arrows #39

Closed
wants to merge 2 commits into from
Closed

Change the type on _onBatch to avoid relying on fuzzy arrows #39

wants to merge 2 commits into from

Conversation

leafpetersen
Copy link
Contributor

munificent
munificent approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Before you land this, can you also:

  • Bump the version in the pubspec.yaml file to 0.9.7+3.
  • Add a quick entry to the CHANGELOG.md explaining the change.

Once this lands, can you let me know and I'll publish the package.

@leafpetersen
Copy link
Contributor Author

Oddly, current pubspec.yaml says 0.9.7+2, but CHANGELOG.md has a 0.9.8 entry. Shall I bump to 0.9.8+1 on the assumption that this was a missed pubspec bump?

@leafpetersen
Copy link
Contributor Author

Pushed a patch as described above, PTAL and let me know if that's the appropriate resolution.

@leafpetersen leafpetersen deleted the fuzzy_arrow_fix branch October 17, 2017 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@munificent munificent munificent approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

directory_watcher/linux.dart has fuzzy arrow warning
3 participants
@leafpetersen @munificent @googlebot