-
Notifications
You must be signed in to change notification settings - Fork 147
Style Guide: AVOID bracketed interpolation of simple identifiers. #1239
Comments
Should also mention that it's OK when followed by alpha numerics: goodprint('\$${dollars}USD'); |
I'll leave to other's on the style council to deem whether this is style guide worthy (ahem @munificent) but I should chime in on this point:
I would turn it around actually: if it's in the style guide it should be in the linter My thinking is that the linter will certainly provide rules that transcend the guide. Indeed it may even have rules that contradict it (or certainly rules that are mutually incompatible with each other). Having said that, there should certainly be a Rule SET provided by the linter that is complete agreement with the guide. |
👍 for having this in the style guide. I would say:
|
Awesome. Where do we go from here? Does @kwalrath own changes or is a pull request welcome? |
Either one is fine, but I can take care of this one. |
👍 Thanks @kwalrath! |
Thanks! |
If it's in the linter:
https://github.com/dart-lang/dart_lint/issues/3
seems like it should then also be in the style guide:
AVOID bracketed interpolation of simple identifiers.
bad
good
"Hi, $name!"
The text was updated successfully, but these errors were encountered: