This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Update to include required 'name' parameter #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream
Update upstream
update simple example to include required 'name' parameter.
|
Thanks Matt! Funny, I just sent out a CL for this exact issue. http://chromiumcodereview.appspot.com/10891023/ Once that CL is reviewed, I'll try to merge our two patches. |
|
Ha ha. Great minds and all that ;) I had noticed the name field was added to the full pubspec document but the getting started page. Particularly the simplest example (formerly empty file). |
|
Thanks Matt. I'm going to close this only because your patch would conflict with my patch that got in just a few hours early. Sorry about the patch collision, thanks for submitting it! We really appreciate you taking the time to clean it up. |
alanjoyce
pushed a commit
to alanjoyce/dartlang.org
that referenced
this pull request
Nov 6, 2013
changed font imports to https
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update pubspec docs