Skip to content
This repository was archived by the owner on Mar 16, 2020. It is now read-only.

Automate release tagging for package. #50

Merged
merged 5 commits into from
Jul 29, 2015
Merged

Conversation

radicaled
Copy link
Contributor

Majority of the work for #49.

@devoncarew

I normally use Rake, so my knowledge of Grinder is pretty limited. The logic works fine, but it's hard-coded to "nextPatch" instead of accepting a command line parameter. You'll probably want to tweak the changelog pattern / output text, too.

}

deployIt() {
// TODO: command line parsing (major, minor, patch) version update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grinder doesn't yet support passing args to tasks, but this is under active development.

@devoncarew
Copy link
Contributor

Very cool!

The logic works fine, but it's hard-coded to "nextPatch" instead of accepting a command line parameter.

Yeah, grinder doesn't yet support passing cli args to individual tasks, but that's currently being developed.

@radicaled
Copy link
Contributor Author

Hm, I must have accidentally butchered this file before committing (that or too many CTRL-Zs by accident). I'll clean it up in a bit.

@radicaled
Copy link
Contributor Author

Yeah, grinder doesn't yet support passing cli args to individual tasks, but that's currently being developed.

This PR is pretty isolated, so it should probably just wait around until that lands in grinder.

@devoncarew
Copy link
Contributor

Here's the grinder issue: google/grinder.dart#175.

@devoncarew
Copy link
Contributor

Hmm, just accidentally published a new version w/o first updating the changelog title from ## unpublished. Perhaps we could land this and iterate on it when grinder args are a thing?

@radicaled
Copy link
Contributor Author

Sounds good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants