Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add Avoid unnecessary setState #346

Merged
merged 9 commits into from
May 26, 2021
Merged

feat: add Avoid unnecessary setState #346

merged 9 commits into from
May 26, 2021

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Closes #332

@incendial incendial added the type: enhancement New feature or request label May 18, 2021
@incendial incendial added this to the 4.0.0 milestone May 18, 2021
@incendial incendial requested a review from dkrutskikh May 18, 2021 18:47
@incendial incendial self-assigned this May 18, 2021
@incendial incendial changed the title feat: add Avoid unnecessary setstate feat: add Avoid unnecessary setState May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #346 (e484bbd) into master (316f32c) will increase coverage by 0.40%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   77.70%   78.10%   +0.40%     
==========================================
  Files         143      145       +2     
  Lines        3315     3385      +70     
==========================================
+ Hits         2576     2644      +68     
- Misses        739      741       +2     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 90.47% <0.00%> (-4.53%) ⬇️
...necessary_setstate/avoid_unnecessary_setstate.dart 100.00% <100.00%> (ø)
...rules_list/avoid_unnecessary_setstate/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316f32c...e484bbd. Read the comment docs.

@incendial incendial requested a review from dkrutskikh May 26, 2021 17:18
@dkrutskikh dkrutskikh merged commit ba7c199 into dart-code-checker:master May 26, 2021
@incendial incendial deleted the implement-avoid-unnecessary-setstate branch May 26, 2021 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New rule] avoid-unnecessary-setstate
2 participants