This repository was archived by the owner on Jul 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 268
feat: add Avoid unnecessary setState #346
Merged
dkrutskikh
merged 9 commits into
dart-code-checker:master
from
incendial:implement-avoid-unnecessary-setstate
May 26, 2021
Merged
feat: add Avoid unnecessary setState #346
dkrutskikh
merged 9 commits into
dart-code-checker:master
from
incendial:implement-avoid-unnecessary-setstate
May 26, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 77.70% 78.10% +0.40%
==========================================
Files 143 145 +2
Lines 3315 3385 +70
==========================================
+ Hits 2576 2644 +68
- Misses 739 741 +2
Continue to review full report at Codecov.
|
dkrutskikh
suggested changes
May 24, 2021
...rs/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart
Outdated
Show resolved
Hide resolved
...rs/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart
Outdated
Show resolved
Hide resolved
...rs/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart
Outdated
Show resolved
Hide resolved
dkrutskikh
approved these changes
May 26, 2021
...nt_analyzer/rules/rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate_test.dart
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Closes #332