Add diagnostics for DTD service detection failures#257
Add diagnostics for DTD service detection failures#257lukemmtt wants to merge 6 commits intodart-lang:mainfrom
Conversation
| CallToolResult get _connectedAppsNotSupported { | ||
| String errorText; | ||
| if (_serviceDetectionError != null) { | ||
| errorText = 'ConnectedApp service not available: $_serviceDetectionError'; |
There was a problem hiding this comment.
Note that in this case it is usually going to be because the user isn't on the required SDK version, so it would be good to include that in the text here?
There was a problem hiding this comment.
@lukemmtt it would be good to resolve this comment as well if you can :)
There was a problem hiding this comment.
Hey @jakemac53 , no problem, although I'm not certain I understood. Is this what you had in mind?
Commit: a91675f
|
@lukemmtt if you would like to land this feel free to move it out of draft, it seems pretty landable to me. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
See the errors, just some simple analysis lints to fix :) |
- Log all registered DTD services when checking for ConnectedApp - Capture and log specific errors instead of silently swallowing exceptions - Add contextual error messages explaining possible causes - Track VM service retrieval failures separately - Make error messages dynamic based on actual failure reason
lukemmtt
force-pushed
the
fix-dtd-error-diagnostics
branch
from
a52f592 to
0026611
Compare
|
Looks like there are still some unformatted files (I think we format with the dev SDK so this could be related possibly). Note also that you don't need to rebase/force push we squash all commits when we merge so the history here doesn't matter (and it makes reviewing better if you don't force push as that destroys history). |
|
Thanks for the tips @jakemac53 🙏🏻 will address these promptly and push, thank you! |
|
Looks like another format is in order |
|
@gspencergoog Just fixed the formatting and merged |
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Looks good, after you update the version numbers.
|
@gspencergoog Changes made; also added a changelog entry, hope that's all good, thanks! |
|
Sorry @lukemmtt it looks like this one totally fell through the cracks. Are you still interested in trying to merge this with main and proceed with landing it? |
3 participants
Adds error logging to help diagnose DTD connection issues reported in #256.
Changes:
This will help identify why the ConnectedApp service detection is failing for some users.