Log print messages at warning #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes up repeatedly that Builder authors are confused when they add print calls and can't see the messages because info lines get overwritten without `--verbose`, and `--verbose` adds a bunch of extra noise that drowns out the wanted messages. Since we expect Builder authors to rely on `log.info` for long term logging they want to keep at info and `print` to be used only for short term stuff it should be safe to up the level to warning.
jakemac53
approved these changes
Aug 6, 2018
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up repeatedly that Builder authors are confused when they add
print calls and can't see the messages because info lines get
overwritten without
--verbose, and--verboseadds a bunch of extranoise that drowns out the wanted messages.
Since we expect Builder authors to rely on
log.infofor long termlogging they want to keep at info and
printto be used only for shortterm stuff it should be safe to up the level to warning.