Skip to content

Run dartfmt --fix to drop new and some const #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2018
Merged

Run dartfmt --fix to drop new and some const #1721

merged 8 commits into from
Aug 7, 2018

Conversation

natebosch
Copy link
Member

Add the unnecessary_new and unnecessary_const lints to prevent new
instances from showing up.

@natebosch
Run dartfmt --fix to drop new and some const
1e348b1 
Add the `unnecessary_new` and `unnecessary_const` lints to prevent new
instances from showing up.
@natebosch
Restore golden
9630abe
@natebosch natebosch requested a review from jakemac53 August 6, 2018 19:52
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Aug 6, 2018
@natebosch
Copy link
Member Author

google/json_serializable.dart#275 makes this tricky because our presubmit checks that the generated files are correct. We can either avoid dartfmt --fix on these files, or wait until json_serializable isn't producing the new anymore...

@jakemac53
Copy link
Contributor

#1726 its not producing new any more!

@natebosch natebosch merged commit a337a90 into master Aug 7, 2018
@natebosch natebosch deleted the no-new branch August 7, 2018 18:57
natebosch added a commit that referenced this pull request Aug 10, 2018
@natebosch
Prepare to back-publish packages with new
16464f8 
Fixes #1746

For each package that was published after #1721 make a `+1` release over
the most recently published version with the same SDK constriaints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natebosch @jakemac53 @googlebot