Glob nodes #1722
Merged
Glob nodes #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Aug 6, 2018
|
|
||
| /// A node representing a glob ran from a builder. | ||
| /// | ||
| /// The [id] must always be unique to a given package, phase, and glob |
There was a problem hiding this comment.
should this constructor generate the id from package/phase/pattern?
There was a problem hiding this comment.
it could but we need to generate these outside of the constructor to check for their existence in the graph as well
There was a problem hiding this comment.
maybe add it as a static method?
| return node.isReadable && node.isValidInput; | ||
| } | ||
|
|
||
| FutureOr<dynamic> _ensureAssetIsBuilt(AssetNode node) { |
There was a problem hiding this comment.
should this be FutureOr<void>?
| doAfter(_updateGlobNodeIfNecessary(globNode), (_) => globNode)); | ||
| } | ||
|
|
||
| FutureOr<Null> _updateGlobNodeIfNecessary(GlobAssetNode globNode) { |
There was a problem hiding this comment.
FutureOr<void> (we'll need to start fixing this elsewhere, but shouldn't introduce new cases)
| } | ||
| globNode.results = actualMatches; | ||
|
|
||
| globNode.state = NodeState.upToDate; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702
GlobAssetNode, and a new interface (NodeWithInputs) for nodes that have some inputs and an invalidation state.findAssets, the glob node gets as inputs all the available nodes, and is invalidated just like any other generated node when those inputs are invalidated.