Skip to content

Add path dep #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add path dep #2002

merged 1 commit into from
Jan 28, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Jan 28, 2019

Explicitly add path dependency before publishing

This dep was added in #2001

@grouma grouma requested review from kevmoo and jakemac53 January 28, 2019 22:55
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jan 28, 2019
@kevmoo
Copy link
Member

kevmoo commented Jan 28, 2019

We need a lint for this!

dart-lang/sdk#57176

@grouma grouma merged commit 48fa54b into master Jan 28, 2019
@grouma grouma deleted the daemon-deps branch January 28, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grouma @kevmoo @googlebot