Skip to content

explicitly skip dart-ext: uris #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2019
Merged

explicitly skip dart-ext: uris #2046

merged 3 commits into from
Feb 13, 2019

Conversation

jakemac53
Copy link
Contributor

At least partially fixes #2045

@jakemac53 jakemac53 requested a review from natebosch February 12, 2019 16:28
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Feb 12, 2019
@natebosch
Copy link
Member

Do you think we need to handle this in build_modules as well?

if (uri.scheme == 'dart') {
sdkDeps.add(uri.path);
continue;
}
var linkedId = AssetId.resolve(path, from: id);

@jakemac53
Copy link
Contributor Author

Do you think we need to handle this in build_modules as well?

Looks like we will need to yes, good catch

@jakemac53
Copy link
Contributor Author

@natebosch pushed a commit to skip these uris during module creation as well, and filed #2047 to track native extension support (but there are no plans to actually work on that unless we have customers for it)

@jakemac53 jakemac53 merged commit 8db23aa into master Feb 13, 2019
@jakemac53 jakemac53 deleted the dart-ext-uris branch February 13, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build runner fails on libraries that indirectly import dart-ext
3 participants