Skip to content

change the ordering of the concatenated kernel files #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build_vm_compilers/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.0.2

- Fix kernel concat ordering to be topological instead of reverse
topological.

## 1.0.1

- Allow analyzer version 0.37.0.
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/lib/src/vm_entrypoint_builder.dart
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-ski

var transitiveKernelModules = [
module.primarySource.changeExtension(vmKernelModuleExtension)
].followedBy(transitiveModules.map(
].followedBy(transitiveModules.reversed.map(
(m) => m.primarySource.changeExtension(vmKernelModuleExtension)));
var appContents = <int>[];
for (var dependencyId in transitiveKernelModules) {
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_vm_compilers
version: 1.0.1
version: 1.0.2
description: Builder implementations wrapping Dart VM compilers.
author: Dart Team <[email protected]>
homepage: https://github.com/dart-lang/build/tree/master/build_vm_compilers
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/test/vm_kernel_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@ void printAsync() async {

expect(runResult.exitCode, 0, reason: runResult.stderr as String);
expect(runResult.stdout, 'before\nrunning\nafter\n');
}, skip: 'https://github.com/dart-lang/sdk/issues/34852');
});
});
}