add flutter sdk support to build_resolvers #2501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2019
natebosch
reviewed
Oct 14, 2019
I think we do essentially have to do that. I want to try and make that only happen for this test suite though. |
natebosch
reviewed
Oct 15, 2019
natebosch
approved these changes
Oct 15, 2019
| var color = classDefinition.getField('color'); | ||
|
|
||
| if (_isFlutter) { | ||
| expect(color.type.name, equals('Color')); |
There was a problem hiding this comment.
[nit] I think we typically haven't used equals in this repo
There was a problem hiding this comment.
🤷♂️ not worth rerunning the ci imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733
We always start with the Dart sdk, but now if we can find the
_embedder.yamlfile for the flutter sdk then we add any libraries found in that to the Dart sdk before summarization.This has the effect of making any flutter libraries available to builds that are using the flutter sdk.
WIP: Still thinking the best way to test this, we probably have to download the whole flutter sdk and run a test using that.Test has been added now.