Conversation
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
I like the changes - thanks! However, I recently landed some somewhat large changes to a few of these objects (hopefully the last). I'll take a look after the merge. |
|
I've rebased my changes to resolve the conflicts. However maybe this isn't the right apporach, I see that the PersistentFrontendServer is now connecting via socket to an existing instance, which when I understand it right is managed by webdev. Is this related to the dwds logic that webdev (and Jaspr) have? Maybe Jaspr can then pass these options there and don't need to go throug build_web_compilers. |
|
|
|
@Markzipan How is the FesManager started? I see it's a script in bin/ but I don't find how it is executed. |
|
@schultek It's started as an aot process by webdev - but this change hasn't landed yet. I'm fine with landing this - and I can add those build options to my change when it's out for review. WIP here: dart-lang/webdev#2836 |
|
@Markzipan I've rebased this on latest master and fixed remaining issues. Are you ok with merging this and I will do a follow up for fes_manager once the webdev changes are landed? |
|
@Markzipan can we merge this, its the last thing blocking the next Jaspr release. |
|
Woops, I've been out for the past ~week! This change LGTM - I'm fine with merging when outstanding issues are resolved. |
This makes DdcFrontendServerBuilder use the same build options as
DevCompilerBuilderfor specifying a custom sdk for building.This is needed for Jaspr to run in "flutter compatibility mode", as added in #4299
As these options are only available during the build phase, the
PersistentFrontendServeris modified to not start immediately when it's created in the resource, but only when the builder callsensureStartedwith the respective options.@Markzipan
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.