[build_web_compilers] Standardize web app entrypoint selection - #5095
Merged
Merged
Conversation
Contributor
Markzipan
approved these changes
Sep 1, 2026
Markzipan
left a comment
Contributor
There was a problem hiding this comment.
LGTM - with a small change.
Note that the final changes to hot reload webdev-side are being added in this change: dart-lang/webdev#2867
after some DWDS-specific glue is landed in our SDK. This may delay formal hot reload support unless it's been handled separately in Jaspr.
Member
Author
|
Thanks for taking a look! Updated. Note the failing test seems to be an unrelated flake that's also timing out on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a stable order for finding web entrypoints when hot reload is enabled. This fixes an issue we were hitting with Jaspr serving where a test file with
mainwas being preferred over an entrypoint in thewebdirectory. Now the following priority is followed, while still ensuring they are entrypoints:web->test->example->benchmark.web/main.dartbeforeweb/a/main.dart.main.dart.This also updates the
web-assets-pathoption to support a YAML list of values rather than just a comma separated list and adds additional validation to the option.