Skip to content

Tests needs update #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue Feb 10, 2022 · 0 comments
Closed

Tests needs update #1300

johnniwinther opened this issue Feb 10, 2022 · 0 comments
Assignees
@iarkh

Comments

@johnniwinther
Copy link
Member

With the landing of [cfe] Check primitive equals in legacy libraries, these tests

co19_2/Language/Statements/Switch/equal_operator_t01
co19_2/Language/Statements/Switch/equal_operator_t02

need to be updated to reflect the now reported errors.
iarkh added a commit that referenced this issue Feb 11, 2022
@iarkh
Fixes #1300: Corrected tests according to the recent changes in CFE.
1b9f593
@iarkh iarkh closed this as completed Feb 11, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 28, 2022
@athomas
[co19] Roll co19_2 to b2034a17609472e374623f3dbe0efd9f5cb258af
048bf38 
2022-03-23 [email protected] Replace InternetAddressType.ANY with InternetAddressType.any (dart-lang/co19#1326)
2022-02-21 [email protected] dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-11 [email protected] Fixes dart-lang/co19#1300: Corrected tests according to the recent changes in CFE.
2022-01-31 [email protected] dart-lang/co19#1281. Expected error location updated
2021-12-13 [email protected] Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check
2021-12-06 [email protected] Issue dart-lang/co19#1094: Runtime executable mode checks moved to Utils/Expect, Language/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected.
2021-11-29 [email protected] More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06 test corrected according to the current dart 2.9 behavior.
2021-11-25 [email protected] More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06.dart updated, Language/Variables/Evaluation_of_Implicit_Variable_Getters comments updated, missing Issue tags added.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/typed_data tests updated according to the changes in master.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Link test updated: changes from master moved to pre-nnbd.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Link tests updated: changes from master moved to pre-nnbd, missung Issue tags added, comments added.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process/killPid_* tests updated.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process tests updated to check process exit code correctly, new test added.

Change-Id: I2f2a857d71b17b568534921ae7edfb517290d9ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239064
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iarkh iarkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iarkh @johnniwinther