Skip to content

Fixes #1344. Wait for entryPoint is invoked before doing the test #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eernstg merged 1 commit into from
Jul 4, 2022
Merged

Fixes #1344. Wait for entryPoint is invoked before doing the test #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions LibTest/isolate/Isolate/kill_A01_t04.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ import "dart:isolate";
import "dart:math";
import "../../../Utils/expect.dart";

entryPoint(message) {
entryPoint(SendPort message) {
message.send("Started");
Random random = new Random();
int s = 0;
while (true) {
Expand All @@ -38,9 +39,11 @@ entryPoint(message) {
}

test() async {
ReceivePort port = new ReceivePort();
ReceivePort onExit = new ReceivePort();
Isolate isolate = await Isolate.spawn(entryPoint, null,
Isolate isolate = await Isolate.spawn(entryPoint, port.sendPort,
onExit: onExit.sendPort, errorsAreFatal: true);
await port.first;
isolate.kill(priority: Isolate.beforeNextEvent);
onExit.first.timeout(Duration(seconds: 3), onTimeout: () {
// This is expected. Isolate shouldn't get killed
Expand Down
2 changes: 1 addition & 1 deletion LibTest/isolate/Isolate/ping_A03_t02.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Future test(List<Object?> values) async {
Isolate isolate = await Isolate.spawn(entryPoint, port.sendPort,
onExit: onExit.sendPort,
errorsAreFatal: true);
var v = await port.first;
await port.first;
List<Future> pingResponses = [];
for (Object? value in values) {
ReceivePort pingPort = new ReceivePort();
Expand Down