Fixes #1372. Expected error message text fixed #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A similar PR is upcoming for the pre-nnbd branch? |
|
@eernstg Hmm. No. Does Horizontal inference feature affect |
|
Oh, maybe I just misremember, but I thought that I saw a failure on both branches about this extra period on the error message, and I didn't notice that there was a connection to horizontal inference. Let me try to find the failure log... |
|
I think it must have been a completely different test, this one is in the |
|
OK, the log is here, I was just misremembering the situation. So we're done, thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 25, 2022
2022-07-25 [email protected] Fixes dart-lang/co19#1372. Expected error message text fixed (dart-lang/co19#1373) 2022-07-22 [email protected] Fixes dart-lang/co19#1356. Add analyzer errors on references to not included library parts (dart-lang/co19#1360) 2022-07-22 [email protected] Fixes dart-lang/co19#1354. Horizontal inference tests added (dart-lang/co19#1358) 2022-07-19 [email protected] Fixes dart-lang/co19#1367. Missed errors expectations added for CFE (dart-lang/co19#1371) 2022-07-14 [email protected] Fix quoting in spec parser command line (dart-lang/co19#1369) 2022-07-14 [email protected] Ignore deleted files in spec parser action (dart-lang/co19#1368) 2022-07-14 [email protected] Pin GitHub actions and setup dependabot (dart-lang/co19#1365) Change-Id: Ib57b9c95b1a50c20a3716383cd6839f65950bac1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252603 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.