#1540. Tests error expectations updated #1544
Conversation
| @@ -22,6 +22,7 @@ class C { | |||
| static set foo(String s) { | |||
| // ^ | |||
| // [analyzer] unspecified | |||
| // [cfe] unspecified | |||
There was a problem hiding this comment.
The indentation is inconsistent here.
|
Hi, @sgrekhov! Could you add just a few words about the nature of these changes? I'm not quite sure what to look for when I'm reviewing. |
This PR fixes #1540. Change https://dart-review.googlesource.com/c/sdk/+/268946 was landed, CFE chander reporting an errors so I'm changing the tests accordingly |
There was a problem hiding this comment.
I do not understand why the code changed from having try/catch to not having it. However, the test was always expecting a compile-time error, so there's no need for a try/catch construct (unless there is some subtle effect associated with control flow analysis, but I can't see how that could be the case in these tests). So it's fine that the try/catch is gone, but it would be nice to hear just a couple of words about this topic. ;-)
The next thing as that, apparently, the CFE used to report an error on call sites for a name-clashed declaration, and that's no longer the case.
So, LGTM!
|
These |
|
OK, thanks! |
2022-12-01 [email protected] Fixes dart-lang/co19#1565. FallThroughError tests removed (dart-lang/co19#1567) 2022-11-14 [email protected] dart-lang/co19#1540. Tests error expectations updated (dart-lang/co19#1544) Change-Id: I4f4904e3c1e002230f4c47c5236fe0f93b18fc8b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273220 Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Michael Thomsen <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
No description provided.