#1959. Test valid combinations of modifiers. Part 1 #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Looks good!
I've added a bunch of comments, mostly typos.
I did suggest that we'd have a comment // Reopen. on every declaration that implies a reopening (and who knows whether I got that right ;-). That might not be very helpful, but I still think it's worth being aware of reopening as a mechanism.
LanguageFeatures/Class-modifiers/syntax_interface_class_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_interface_class_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_interface_class_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_interface_class_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_interface_class_A04_t01.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Apr 19, 2023
LanguageFeatures/Class-modifiers/syntax_final_class_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_final_class_A04_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Class-modifiers/syntax_interface_class_A04_t01.dart
Outdated
Show resolved
Hide resolved
|
@eernstg please merge this PR |
Fixed syntax error (mixin application class with body --> with semicolon).
|
Ah, yes, I forgot: There is a syntax error in LanguageFeatures/Class-modifiers/syntax_sealed_class_A04_t01.dart, a mixin application class with a body. Fixed that. Landing. |
|
Thank you! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 24, 2023
2023-04-19 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 1 (dart-lang/co19#2023) 2023-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (dart-lang/co19#2022) 2023-04-17 [email protected] dart-lang/co19#1959. More basic and mixin restrictions tests (dart-lang/co19#2021) 2023-04-17 [email protected] dart-lang/co19#1959. Tests for syntax and basic restrictions (dart-lang/co19#2017) Change-Id: I0d27a6b3504eb13351e72d8dac6281ff0aa52fc7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296802 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only first half of the changes but, I believe, it's big enough for review. Some test case scipped because they are already tested in
basic_restrictions*tests