Skip to content

#1959. Test valid combinations of modifiers. Part 2 #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2023
Merged

#1959. Test valid combinations of modifiers. Part 2 #2024

merged 4 commits into from
Apr 24, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Just a couple of types.

sgrekhov
sgrekhov commented Apr 24, 2023
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests updated. I'm only not sure if base mixin on a final class is a reopen situation or not

eernstg
eernstg approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@eernstg
Copy link
Member

eernstg commented Apr 24, 2023

I'm closing the thread about the reopening at an on type, whatever we will do about this will not happen in this PR. I did comment on it, in order to get it clarified a bit.

@eernstg eernstg merged commit 07ad974 into dart-lang:master Apr 24, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 28, 2023
@sgrekhov
[co19] Roll co19 to fc31789eadd5a664fe25e69cb966555e78a65d0d
cda6ab5 
2023-04-25 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 3 (dart-lang/co19#2025)
2023-04-25 [email protected] Fixes dart-lang/co19#2027. Hint expectation added (dart-lang/co19#2028)
2023-04-24 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 2 (dart-lang/co19#2024)

Change-Id: I32326cf0be0e3ac7a0ac901ea476213083307355
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299520
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1959-4 branch July 18, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg