Fixes #2668. Reorder switch expressions to avoid flow analysis secondary issues #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is secondary issues
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 3, 2024
2024-05-30 [email protected] dart-lang/co19#2641. Add super parameters tests (dart-lang/co19#2687) 2024-05-29 [email protected] Fixes dart-lang/co19#2678. Add more extension types static vs instance conflict tests (dart-lang/co19#2692) 2024-05-29 [email protected] Fixes dart-lang/co19#2668. Reorder switch expressions to avoid flow analysis secondary issues (dart-lang/co19#2693) 2024-05-28 [email protected] dart-lang/co19#2641. Add external functions and covariant parameters tests (dart-lang/co19#2691) 2024-05-28 [email protected] Fixes dart-lang/co19#2689. Add more extension methods tests (dart-lang/co19#2690) 2024-05-27 [email protected] dart-lang/co19#2641. Add extension types tests (dart-lang/co19#2688) [email protected] Change-Id: Ie5c551e3198e748b55d45ec5039d1ff836444ee2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369000 Auto-Submit: Sergey Grekhov <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix suggested in this comment dart-lang/sdk#53392 (comment) doesn’t work. Adding
{...}doesn’t help, but reordering does.It’s hard for me to explain why I preserved
i4expecting no error. To me, it seems useful to have these issues somewhere in the tests. If, one day, someone fixes it (probably unintentionally), and flow analysis starts reporting an error fori4too, then the tests will fail, and the author will know that (s)he fixed it as well.If you believe that it is not necessary, let me know, and I’ll remove it. At least there is no issue in real life. To make the code work, people have to fix all their issues, and eventually, the unreported ones become the first one and will be reported.