#3847. Add function literal inference tests for return type. Part 3.#3940
Merged
Conversation
Contributor
Author
|
@eernstg please review |
eernstg
reviewed
Jul 15, 2026
eernstg
left a comment
eernstg
left a comment
Member
There was a problem hiding this comment.
Looks good!
One thing may slip through, though: I think a compiler/analyzer could conclude that the return type of a number of function literals can be Object? or some other top type which is not void, and the existing tests will not detect the issue. So we will probably need to have some void specific tests confirming that it is an error to use those returned values..
Contributor
Author
|
Updates as suggested. PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review, it's enough to review only the top-level functions. The rest of the code repeats these functions as static and instance members of classes, mixins, mixin classes, enums, extensions, and extension types.