Don't touch files whose contents do not change. Fix #127.

BUG=#127
[email protected]

Review URL: https://chromiumcodereview.appspot.com//850953004

Author: munificent

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 * Split different operators with the same precedence equally (#130).
 * No spaces for empty for loop clauses (#132).
+* Don't touch files whose contents did not change (#127).
 
 # 0.1.2
 

lib/src/io.dart

@@ -38,10 +38,15 @@ void processFile(File file, {String label, bool overwrite, int pageWidth}) {
 
   var formatter = new DartFormatter(pageWidth: pageWidth);
   try {
-    var output = formatter.format(file.readAsStringSync(), uri: file.path);
+    var source = file.readAsStringSync();
+    var output = formatter.format(source, uri: file.path);
     if (overwrite) {
-      file.writeAsStringSync(output);
-      print("Formatted $label");
+      if (source != output) {
+        file.writeAsStringSync(output);
+        print("Formatted $label");
+      } else {
+        print("Unchanged $label");
+      }
     } else {
       // Don't add an extra newline.
       stdout.write(output);

test/io_test.dart

@@ -4,6 +4,7 @@
 
 library dart_style.test.io;
 
+import 'dart:async';
 import 'dart:io';
 
 import 'package:dart_style/src/io.dart';
@@ -51,6 +52,41 @@ void main() {
     ]).validate();
   });
 
+  test("doesn't touch unchanged files", () {
+    d.dir('code', [
+      d.file('bad.dart', _SOURCE),
+      d.file('good.dart', _FORMATTED),
+    ]).create();
+
+    modTime(String file) {
+      return new File(p.join(d.defaultRoot, 'code', file)).statSync().modified;
+    }
+
+    var badBefore;
+    var goodBefore;
+
+    schedule(() {
+      badBefore = modTime('bad.dart');
+      goodBefore = modTime('good.dart');
+
+      // Wait a bit so the mod time of a formatted file will be different.
+      return new Future.delayed(new Duration(seconds: 1));
+    });
+
+    schedule(() {
+      var dir = new Directory(p.join(d.defaultRoot, 'code'));
+      processDirectory(dir, overwrite: true);
+
+      // Should be touched.
+      var badAfter = modTime('bad.dart');
+      expect(badAfter, isNot(equals(badBefore)));
+
+      // Should not be touched.
+      var goodAfter = modTime('good.dart');
+      expect(goodAfter, equals(goodBefore));
+    });
+  });
+
   test("doesn't follow directory symlinks by default", () {
     d.dir('code', [
       d.file('a.dart', _SOURCE),