Skip to content

dart format should exit non-zero if the source code has errors #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natebosch opened this issue Jun 15, 2021 · 5 comments · Fixed by #1036
Closed

dart format should exit non-zero if the source code has errors #1035

natebosch opened this issue Jun 15, 2021 · 5 comments · Fixed by #1036

Comments

@natebosch
Copy link
Member

echo 'not dart' | dartfmt and echo 'not dart' | dart format both produce equivalent error messages, but dartfmt exits with code 65 while dart format exits with 0.

We use the exit code in dart-vim-plugin to know whether the output should be treated as the formatted file, or as errors. Unfortunately in vim it isn't trivial to distinguish between stderr and stdout so using the output stream to determine success would take some additional hacking and running the command twice.
@mit-mit
Copy link
Member

mit-mit commented Jun 16, 2021

cc @munificent

@munificent
Copy link
Member

@bkonyi, the FormatCommand in dart_style should be setting the exit code (test here. Is it possible the dart command isn't plumbing it through?

@bkonyi
Copy link
Contributor

bkonyi commented Jun 17, 2021

@munificent we set the exit code based on the return value from runCommand. If you're setting the dart:io exitCode it'll be ignored.

@munificent munificent transferred this issue from dart-lang/sdk Jun 17, 2021
munificent added a commit that referenced this issue Jun 18, 2021
@munificent
Return correct exit code from FormatCommand when formatting stdin.
a552e77 
It reads from stdin asynchronously. Before this fix, the FormatCommand
did not wait for that to complete before returning the exit code, so it
would return before stdin had been formatted and any parse error
detected.

Fix #1035.
@munificent munificent mentioned this issue Jun 18, 2021
Merged
@munificent munificent reopened this Jun 21, 2021
@munificent
Copy link
Member

This is fixed in the dart_style repo, but I'm going to keep this issue open until I've rolled the fix into the SDK.

@munificent
Copy link
Member

This is in the SDK and published now.

@fishythefish fishythefish mentioned this issue Jul 14, 2021
Merged
@cbracken cbracken mentioned this issue Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return correct exit code from FormatCommand when formatting stdin. dart-lang/dart_style
4 participants
@munificent @natebosch @mit-mit @bkonyi