Get the test updater script working again. #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I made the style changes language versions for Dart 3.8, I changed how tests are written to allow a single test to have different expected outputs at different language versions. I was pressed for time, so that broke the automated test updater which doesn't know how to handle versions. This gets it working again. In the process, I decided to tweak how the final newline in test files is handled. For years, I avoided having a trailing newline because I though it would confuse the formatter. At some point that may have even been true. But it turns out to be fine and it's more idiomatic to have a trailing newline at the end of a text file. The test updater now ensures that and I went ahead and normalized all of the tests to have trailing newlines. There are no other changes to the test files.
kallentu
approved these changes
Jul 17, 2025
munificent
added a commit
that referenced
this pull request
Jul 28, 2025
When I made the style changes language versions for Dart 3.8, I changed how tests are written to allow a single test to have different expected outputs at different language versions. I was pressed for time, so that broke the automated test updater which doesn't know how to handle versions. This gets it working again. In the process, I decided to tweak how the final newline in test files is handled. For years, I avoided having a trailing newline because I though it would confuse the formatter. At some point that may have even been true. But it turns out to be fine and it's more idiomatic to have a trailing newline at the end of a text file. The test updater now ensures that and I went ahead and normalized all of the tests to have trailing newlines. There are no other changes to the test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I made the style changes language versions for Dart 3.8, I changed how tests are written to allow a single test to have different expected outputs at different language versions.
I was pressed for time, so that broke the automated test updater which doesn't know how to handle versions. This gets it working again.
In the process, I decided to tweak how the final newline in test files is handled. For years, I avoided having a trailing newline because I though it would confuse the formatter. At some point that may have even been true. But it turns out to be fine and it's more idiomatic to have a trailing newline at the end of a text file.
The test updater now ensures that and I went ahead and normalized all of the tests to have trailing newlines. There are no other changes to the test files. The only actual change in this PR is at the very end in
tool/update_tests.dart.