Support optional new/const. #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In almost all cases, an elided "new"/"const" is parsed as a normal method call by analyzer, so the existing formatting behavior for those does the right thing. The only edge case is a named constructor on a generic class. That syntax can *only* be a constructor call, so it's parsed as an instance creation expression. When we get to that code path, we need to not add an extra space before the class name if there is no preceding "new" or "const" keyword. Fix #652.
# Conflicts: # pubspec.lock # test/whitespace/type_arguments.stmt
kevmoo
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In almost all cases, an elided "new"/"const" is parsed as a normal
method call by analyzer, so the existing formatting behavior for those
does the right thing. The only edge case is a named constructor on a
generic class. That syntax can only be a constructor call, so it's
parsed as an instance creation expression.
When we get to that code path, we need to not add an extra space before
the class name if there is no preceding "new" or "const" keyword.
Fix #652.