Skip to content

Commit 2fd47d3

Browse files
authored
Fix annotation templates and renderer (#2605)
* Fix annotation templates and renderer * remove extra annotation
1 parent 31ec93e commit 2fd47d3

16 files changed

+1678
-1358
lines changed

lib/src/generator/templates.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Annotations only appear on other pages, so there is no template data here.
6+
@Renderer(#renderAnnotation, Context<Annotation>())
57
@Renderer(#renderCategory, Context<CategoryTemplateData>(),
68
visibleTypes: _visibleTypes)
79
@Renderer(#renderClass, Context<ClassTemplateData>())
@@ -28,6 +30,7 @@ import 'package:dartdoc/dartdoc.dart';
2830
import 'package:dartdoc/options.dart';
2931
import 'package:dartdoc/src/generator/resource_loader.dart';
3032
import 'package:dartdoc/src/generator/template_data.dart';
33+
import 'package:dartdoc/src/model/annotation.dart';
3134
import 'package:dartdoc/src/model/feature_set.dart';
3235
import 'package:dartdoc/src/model/language_feature.dart';
3336
import 'package:dartdoc/src/mustachio/annotations.dart';
@@ -36,6 +39,7 @@ import 'package:meta/meta.dart';
3639
import 'package:path/path.dart' as path show Context;
3740

3841
const _visibleTypes = {
42+
Annotation,
3943
CallableElementTypeMixin,
4044
Category,
4145
Class,

lib/src/generator/templates.renderers.dart

Lines changed: 1658 additions & 1346 deletions
Large diffs are not rendered by default.

lib/templates/html/_callable_multiline.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div>
33
<ol class="annotation-list">
44
{{#annotations}}
5-
<li>{{{.}}}</li>
5+
<li>{{{linkedNameWithParameters}}}</li>
66
{{/annotations}}
77
</ol>
88
</div>

lib/templates/html/_type_multiline.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div>
33
<ol class="annotation-list">
44
{{#annotations}}
5-
<li>{{{.}}}</li>
5+
<li>{{{linkedNameWithParameters}}}</li>
66
{{/annotations}}
77
</ol>
88
</div>

lib/templates/html/class.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
7070
<dt>Annotations</dt>
7171
<dd><ul class="annotation-list clazz-relationships">
7272
{{#annotations}}
73-
<li>{{{.}}}</li>
73+
<li>{{{linkedNameWithParameters}}}</li>
7474
{{/annotations}}
7575
</ul></dd>
7676
{{/hasAnnotations}}

lib/templates/html/constructor.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
1717
<div>
1818
<ol class="annotation-list">
1919
{{#annotations}}
20-
<li>{{{.}}}</li>
20+
<li>{{{linkedNameWithParameters}}}</li>
2121
{{/annotations}}
2222
</ol>
2323
</div>

lib/templates/html/enum.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
6161
<dt>Annotations</dt>
6262
<dd><ul class="annotation-list eNum-relationships">
6363
{{#annotations}}
64-
<li>{{{.}}}</li>
64+
<li>{{{linkedNameWithParameters}}}</li>
6565
{{/annotations}}
6666
</ul></dd>
6767
{{/hasAnnotations}}

lib/templates/html/mixin.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
7070
<dt>Annotations</dt>
7171
<dd><ul class="annotation-list mixin-relationships">
7272
{{#annotations}}
73-
<li>{{{.}}}</li>
73+
<li>{{{linkedNameWithParameters}}}</li>
7474
{{/annotations}}
7575
</ul></dd>
7676
{{/hasAnnotations}}

lib/templates/md/_callable_multiline.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{#hasAnnotations}}
22
{{#annotations}}
3-
- {{{.}}}
3+
- {{{linkedNameWithParameters}}}
44
{{/annotations}}
55
{{/hasAnnotations}}
66

lib/templates/md/_type_multiline.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{#hasAnnotations}}
22
{{#annotations}}
3-
- {{{.}}}
3+
- {{{linkedNameWithParameters}}}
44
{{/annotations}}
55
{{/hasAnnotations}}
66

lib/templates/md/class.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
**Annotations**
5959

6060
{{#annotations}}
61-
- {{{.}}}
61+
- {{{linkedNameWithParameters}}}
6262
{{/annotations}}
6363
{{/hasAnnotations}}
6464
{{/hasModifiers}}

lib/templates/md/constructor.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
{{#constructor}}
1111
{{#hasAnnotations}}
1212
{{#annotations}}
13-
- {{{.}}}
13+
- {{{linkedNameWithParameters}}}
1414
{{/annotations}}
1515
{{/hasAnnotations}}
1616

lib/templates/md/enum.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
**Annotations**
5050

5151
{{#annotations}}
52-
- {{{.}}}
52+
- {{{linkedNameWithParameters}}}
5353
{{/annotations}}
5454
{{/hasAnnotations}}
5555
{{/hasModifiers}}

lib/templates/md/mixin.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
**Annotations**
5959

6060
{{#annotations}}
61-
- {{{.}}}
61+
- {{{linkedNameWithParameters}}}
6262
{{/annotations}}
6363
{{/hasAnnotations}}
6464
{{/hasModifiers}}

test/mustachio/foo.renderers.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
import 'package:analyzer/file_system/file_system.dart';
99
import 'package:dartdoc/dartdoc.dart';
1010
import 'package:dartdoc/src/generator/template_data.dart';
11+
import 'package:dartdoc/src/model/annotation.dart';
12+
import 'package:dartdoc/src/model/feature.dart';
1113
import 'package:dartdoc/src/model/extension_target.dart';
1214
import 'package:dartdoc/src/model/feature_set.dart';
1315
import 'package:dartdoc/src/model/language_feature.dart';

tool/mustachio/codegen_runtime_renderer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ class RuntimeRenderersBuilder {
9090
import 'package:analyzer/file_system/file_system.dart';
9191
import 'package:dartdoc/dartdoc.dart';
9292
import 'package:dartdoc/src/generator/template_data.dart';
93+
import 'package:dartdoc/src/model/annotation.dart';
94+
import 'package:dartdoc/src/model/feature.dart';
9395
import 'package:dartdoc/src/model/extension_target.dart';
9496
import 'package:dartdoc/src/model/feature_set.dart';
9597
import 'package:dartdoc/src/model/language_feature.dart';

0 commit comments

Comments
 (0)