Skip to content

Fix annotation templates and renderer #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2021
Merged

Fix annotation templates and renderer #2605

merged 2 commits into from
Apr 5, 2021

Conversation

jcollins-g
Copy link
Contributor

Fix a problem introduced in #2600 where the templates were effectively doing toString() on annotations instead of calling the correct members.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Apr 2, 2021
@jcollins-g jcollins-g merged commit 2fd47d3 into dart-lang:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@srawlins srawlins Awaiting requested review from srawlins

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcollins-g @devoncarew