Major refactor of dartdoc "features" and annotations #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Apr 2, 2021
lib/src/model/container_member.dart
Outdated
| return _features; | ||
| } | ||
| Set<Feature> get features => | ||
| {...super.features, if (isExtended) Feature.extended}; |
There was a problem hiding this comment.
If this will be more readable on multiple lines, a trailing comma will force that.
lib/src/model/feature.dart
Outdated
| } | ||
|
|
||
| /// A "feature" includes both explicit annotations in code (e.g. `deprecated`) | ||
| /// as well as others added by the documentation systme (`read-write`); |
| // TODO(jcollins-g): consider [Comparable]? | ||
| final int sortGroup; | ||
|
|
||
| static const readOnly = Feature('read-only', 1); |
There was a problem hiding this comment.
Haha I had this exact same idea. Excellent.
lib/src/model/model_element.dart
Outdated
| Iterable<Annotation> _annotations; | ||
| // Skips over annotations with null elements or that are otherwise | ||
| // supposed to be invisible (@pragma). While technically they are | ||
| // invalid code from analyzer's perspective they are present in sky_engine |
There was a problem hiding this comment.
I'm not sure how to read this sentence. An annotation like @pragma is invalid? Does invalid mean analyzer crashes or something?
There was a problem hiding this comment.
This got lost in multiple rewrites; the only indicator of invalid code is the null element. Updated.
| @@ -0,0 +1,63 @@ | |||
| // Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
sure. this was actually a rename from the old "FeatureRenderer".
This was referenced Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2516.
Should supercede #2595 and #2599. Most of this is the refactor; once that's done, the implementation for type parameters is trivial.